search

SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Add primary partner name to project workflow notification #3210

Closed atGit2021 closed 2 months ago

atGit2021 commented 2 months ago

Monday task https://seed-company-squad.monday.com/boards/5989610236/pulses/6509819818

atGit2021 commented 2 months ago

I wouldn't do all this refactoring in this same PR with the business logic change. Additionally, it needs to be rewritten all together to match progress report workflow. This is the only way EdgeDB will be able to use "previous step".

@CarsonF are you referring to creating the new module and splitting out the two repo files in order to port to edgedb? If so, should I revert all the edge related work and only test to make sure it works on the neo4j side?

CarsonF commented 2 months ago

@CarsonF are you referring to creating the new module and splitting out the two repo files in order to port to edgedb? If so, should I revert all the edge related work and only test to make sure it works on the neo4j side?

Yes and yes

atGit2021 commented 2 months ago

@CarsonF I tried to get a rid of a conflict that was only showing on the remote side, but not sure if I did it correctly and why I don't see these errors on my local.

atGit2021 commented 2 months ago

@CarsonF tests look good!