Closed atGit2021 closed 1 month ago
I'd rather have the PR come from myself for this for historical records and since it's so large.
Sorry, I created a branch off of your branch for the 0883 task and thought it would be a separate PR, but after I opened it I realized it just gets added to your project-workflow PR.
I also created a cordfield repo PR for the front end work, but I needed a backend PR to tie it too so the schema would not throw errors during the CI tests
Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Carson Full @.> Sent: Friday, June 7, 2024 7:59:37 AM To: SeedCompany/cord-api-v3 @.> Cc: Andre Turner @.>; Author @.> Subject: Re: [SeedCompany/cord-api-v3] WIP (PR #3229)
I'd rather have the PR come from myself for this for historical records and since it's so large.
— Reply to this email directly, view it on GitHubhttps://github.com/SeedCompany/cord-api-v3/pull/3229#issuecomment-2154787351, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATAHBQJW4BQ5N5VTT5V4H2TZGGVDTAVCNFSM6AAAAABI22WMYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUG44DOMZVGE. You are receiving this because you authored the thread.Message ID: @.***>
Sorry, I created a branch off of your branch for the 0883 task and thought it would be a separate PR, but after I opened it I realized it just gets added to your project-workflow PR.
np that one just needs the base branch changed to this branch. I'll do that. I'll still use this branch to make a PR.
I also created a cordfield repo PR for the front end work, but I needed a backend PR to tie it too so the schema would not throw errors during the CI tests
Yeah that's valid. I probably would've made a draft PR for you for that. That one is cool hanging out for a bit though. This work doesn't have breaking changes.
Creating Draft PR in order to tie this to the front end PR