Closed willdch closed 4 months ago
My only remaining comment, is that the ProjectOverview uses the default Chip font size which is 13px, but everywhere else (in lists) its explicitly body2
which is size 14px.
We should pick one size and use that as the default for all chips.
My only remaining comment, is that the ProjectOverview uses the default Chip font size which is 13px, but everywhere else (in lists) its explicitly
body2
which is size 14px.We should pick one size and use that as the default for all chips.
@willdch is working on that
@willdch @andrewmurraydavid I rejiggered the commits here to be single responsibility so we don't need to squash.
I also removed the body2
size.
Want to give it a final look over before I merge?
Apollo doesn't make a call to fetch when switching between Momentum and Multiplication.
Wdym? how to reproduce?
ok, not apollo, but the call to the API doesn't go through because it thinks it's cached.
I said apollo since it's responsible with caching as i recall.
To reproduce, go to the Project list, select Internship, apply and you will see the Internship projects. Then select multiplication and you will see Momentum, not multiplication.
I just confirmed, @CarsonF , it's still happening
API PR: https://github.com/SeedCompany/cord-api-v3/pull/3160
Monday task
Description
Added a chip displaying the project type on the Project Card, Project Overview Page and Partner table project tab.
Project Card:
Project Overview:
Partner Table Project tab:
Ready for review checklist