SeedCompany / cord-field

CORD UI
MIT License
7 stars 3 forks source link

Adapt to TranslationProject Split & add type chips to UI #1526

Closed willdch closed 4 months ago

willdch commented 5 months ago

API PR: https://github.com/SeedCompany/cord-api-v3/pull/3160

Monday task

Description

Added a chip displaying the project type on the Project Card, Project Overview Page and Partner table project tab.

Project Card: Screenshot 2024-04-08 at 3 44 50 PM

Project Overview: Screenshot 2024-04-08 at 3 45 11 PM

Partner Table Project tab: Screenshot 2024-04-09 at 11 19 29 AM

Ready for review checklist

Use [N/A] if the item is not applicable to this PR or remove the item

  • [x] Change the task url above to the actual Monday task
  • [ NA] Add/update tests if needed
  • [x] Add reviewers to this PR
CarsonF commented 4 months ago

My only remaining comment, is that the ProjectOverview uses the default Chip font size which is 13px, but everywhere else (in lists) its explicitly body2 which is size 14px.

We should pick one size and use that as the default for all chips.

andrewmurraydavid commented 4 months ago

My only remaining comment, is that the ProjectOverview uses the default Chip font size which is 13px, but everywhere else (in lists) its explicitly body2 which is size 14px.

We should pick one size and use that as the default for all chips.

@willdch is working on that

CarsonF commented 4 months ago

@willdch @andrewmurraydavid I rejiggered the commits here to be single responsibility so we don't need to squash. I also removed the body2 size.

Want to give it a final look over before I merge?

CarsonF commented 4 months ago

Apollo doesn't make a call to fetch when switching between Momentum and Multiplication.

Wdym? how to reproduce?

andrewmurraydavid commented 4 months ago

ok, not apollo, but the call to the API doesn't go through because it thinks it's cached.

I said apollo since it's responsible with caching as i recall.

To reproduce, go to the Project list, select Internship, apply and you will see the Internship projects. Then select multiplication and you will see Momentum, not multiplication.

andrewmurraydavid commented 4 months ago

I just confirmed, @CarsonF , it's still happening