SeedLabs-it / smartknob-firmware

Repository for the Smart Knob Firmware (Currently supporting Dev Kit v0.1)
Other
30 stars 5 forks source link

QR-code / AP view in onboarding has low FPS #31

Closed nicolabortignon closed 7 months ago

nicolabortignon commented 9 months ago

Drops to 12 from 20. goes back to 20 when clicking out.

nicolabortignon commented 9 months ago

@carlhampuswall I run some test, the culprit is this line https://github.com/SeedLabs-it/smart-knob-firmware/blob/9c3df5e0de16da62716b7e0a7f084d79d9b8becd/firmware/src/apps/onboarding/hass_setup.cpp#L55

I'm not sure if you are using that method correctly, but assuming you are, I would move it outside the rendering method, and statically compute with the class. (I expect the QRCODE url not to change). In this way you take the computational hit only once.