search

SeedSigner / seedsigner-os

SeedSigner OS | Minimal Raspberry Pi image made for SeedSigner
MIT License
97 stars 25 forks source link

Stop build when git clone fails #41

Closed newtonick closed 1 year ago

newtonick commented 1 year ago

Currently, in the build.sh script the git clone step can fail (invalid branch as an example) and the build will continue. Instead it would be better if the build.sh script exited on failure to clone the repo. This PR adds an exit 1 on the git clone step.

DesobedienteTecnologico commented 1 year ago

Great catch that! Thanks.

Should we add also that into the repository line? Just in case when doing the building without internet access or in case the host do not reach that repository for whatever reason? What do you think?

newtonick commented 1 year ago

Great catch that! Thanks.

Should we add also that into the repository line? Just in case when doing the building without internet access or in case the host do not reach that repository for whatever reason? What do you think?

Which line in build.sh script? There is only the one git clone command pulling from the internet in the build.sh script. I'm pretty sure that the buildroot make command would also fail without internet.

DesobedienteTecnologico commented 1 year ago

LGTM.