search

SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
691 stars 158 forks source link

Include an incorrect Standard SeedQR test vector #251

Open moneymanolis opened 1 year ago

moneymanolis commented 1 year ago

While reviewing @kdmukai implementation of the Standard SeedQR format in Specter Desktop https://github.com/cryptoadvance/specter-desktop/pull/1870 and adding tests to it I realised that there only correct Standard SeedQR test vectors on https://github.com/SeedSigner/seedsigner/blob/dev/docs/seed_qr/README.md. I think it would be good to include at least one with, say, a 4-digit number above 2047, to make testing of edge cases in the respective implementations more straightforward.

SeedSigner commented 1 year ago

Seems reasonable to me but @kdmukai would have the best perspective.

moneymanolis commented 1 year ago

Just fyi, I've included one pytest regarding this edge case in this commit: https://github.com/cryptoadvance/specter-desktop/pull/1870/commits/5a17507b3ec6ed8279f49ab96c5fd91c7e1433ba