SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
711 stars 163 forks source link

[Enhancement] Create uniform registration box appearance on 25x25 and 29x29 size QR code backup #381

Open bitcoinprecept opened 1 year ago

bitcoinprecept commented 1 year ago

Multiple seedsigner users have noticed over the last year that when working through the QR code backup flow on sizes 25x25 and 29x29, the small bottom-right registration box is not displayed the same as the primary three larger registration boxes. Seedsigner contributors @kdmukai and @Marc-Gee had both worked on this issue in the past but no "fix" has been pushed into a release build as of yet.

It looks like Seedsigner is using the CircleModuleDrawer() output option from the underlying python-qrcode, according to notes from @newtonick. At present, the three main boxes have a distinct square pattern and the bottom right is displayed as dots. The easiest solution for the seedsigner developers would be for the underlying python code set to be updated. To this end I have created Issue 334 directly within that repository.

It still may be possible for a seedsigner developer to conceive of an alternative solution to this problem that is not dependent on outside code bases. As such, I felt it also prudent to log an enhancement request here directly in the seedsigner repo.

Target area: IMG_9313

Real life screenshots: IMG_9312 IMG_9310 IMG_9311

This is a very minor point but given that multiple users have noticed/complained about this over the last year, it felt prudent to highlight as an enhancement request here. A less confusing user experience when transcribing QR code backups by hand using the seedsigner would be for all 4 registration boxes to have the same appearance, distinct from the dots of the user-specific data.

Marc-Gee commented 1 year ago

Thank you @bitcoinprecept for doing such thorough analysis of the issue! 👍