SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
721 stars 168 forks source link

[Enhancement] Additional edge padding for Warning Screen body text #461

Closed kdmukai closed 1 year ago

kdmukai commented 1 year ago

The problem

Current Warning Screens use the standard GUIConstants.EDGE_PADDING for the left and right limits for the body text. But the pulsing yellow or red warning edges fill that edge padding. Depending on the line breaks, text can potentially directly touch the pulsing warning edges.

The fix

Double the default edge padding for Warning Screens.


Before / After (unfortunately we can't currently render the yellow/red warning edges, so just imagine the edges being filled in)

ErrorView-before ErrorView-after

This change affects all Warning Screens, so you must regenerate screenshots to see the changes.

PSBTNoChangeWarningView-before PSBTNoChangeWarningView-after


Additional changes


Follow-up steps

If merged, generate new screenshots and update https://github.com/SeedSigner/seedsigner-screenshots

jdlcdl commented 1 year ago

As of 0883c8e

ACK tested

I used an invalid qrcode and it was easy to see this improvement (SettingsQR via Seeds/ScanSeed).

newtonick commented 1 year ago

ACK Tested