Current Warning Screens use the standard GUIConstants.EDGE_PADDING for the left and right limits for the body text. But the pulsing yellow or red warning edges fill that edge padding. Depending on the line breaks, text can potentially directly touch the pulsing warning edges.
The fix
Double the default edge padding for Warning Screens.
Before / After
(unfortunately we can't currently render the yellow/red warning edges, so just imagine the edges being filled in)
This change affects all Warning Screens, so you must regenerate screenshots to see the changes.
Additional changes
Adds a screenshot for the generic ErrorView
Pulls the more general errors out into their own section at the end of the screenshot generator output
Renames the example SettingsQR since "factory reset" terminology only makes sense for a retail product.
The problem
Current Warning Screens use the standard
GUIConstants.EDGE_PADDING
for the left and right limits for the body text. But the pulsing yellow or red warning edges fill that edge padding. Depending on the line breaks, text can potentially directly touch the pulsing warning edges.The fix
Double the default edge padding for Warning Screens.
Before / After (unfortunately we can't currently render the yellow/red warning edges, so just imagine the edges being filled in)
This change affects all Warning Screens, so you must regenerate screenshots to see the changes.
Additional changes
ErrorView
Follow-up steps
If merged, generate new screenshots and update https://github.com/SeedSigner/seedsigner-screenshots