search

SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

unittests for new settings defaults: msg-signing/qr-brightness-tips #466

Closed jdlcdl closed 1 year ago

jdlcdl commented 1 year ago

Adds 2 unit-tests for new settings defaults in 0.7.0.

The tests/test_controller.py tests all settings defaults as its last test. It's extra maintenance, but it's also helpful for us not to accidentally change defaults without also updating the unit-test, also helpful for keeping settings-generator in line with seedsigner settings defaults.

kdmukai commented 1 year ago

The test in general feels just barely useful enough to offset its DRY offenses, but that's not a critique of this PR.

Since the test is there, ya, let's at least update it to the current settings options. But maybe a simpler test (in a later PR) that just spot-checks different types of defaults would be sufficient going forward.

ACK tested.

newtonick commented 1 year ago

ACK