SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

[Enhancement] Render SeedQR small registration block in solid squares #484

Closed kdmukai closed 7 months ago

kdmukai commented 1 year ago

fixes #483

Renders the lower-right registration block in 25x25 and 29x29 SeedQRs as solid squares instead of dots.

Before vs after: SeedTranscribeSeedQRWholeQRView_12_Standard SeedTranscribeSeedQRWholeQRView_12_Standard

And the same rendering improvement is continued in the zoomed-in transcription UI:


Supplements screenshot generator with:


Briefly tried and quickly gave up on getting the zoomed in transcription UI to render in the screenshot generator (just comes out all black). TODO for another day.

newtonick commented 1 year ago

ACK and Tested without issue. I'll review the code at some later time before merging.

jdlcdl commented 1 year ago

ACK tested.

super clean, really helps with maintaining orientation while transcribing sectors all around that alignment marker.

kdmukai commented 1 month ago

Fixes #381