SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

Use mock from Python stdlib and upgrade test requirements versions #491

Closed dbast closed 7 months ago

dbast commented 1 year ago

Description

mock is part of the Python standard lib since Python 3.3, see also https://docs.python.org/3/library/unittest.mock.html. Switching to that allows to remove it from test/requirements.txt.

While at it, also updating the package versions in test/requirements.txt.

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

jdlcdl commented 1 year ago

Seems safe enough to me.

ACK tested

kdmukai commented 8 months ago

Tested ACK.

Full test suite has no complaints (coverage run -m pytest). Screenshot generator has no complaints (pytest tests/screenshot_generator/generator.py)

Ran the tests in local dev virtualenv on macOS.

newtonick commented 7 months ago

ACK Tested on RaspiOS local dev build and on macOS.