SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

Enable image builds with badge and add os-ref param for manual builds #493

Closed dbast closed 6 months ago

dbast commented 1 year ago

This updates the existing build action to:

For more details see inline comments.

Succeeding PRs can also enable builds for every merge to the dev/main branch or for triggering builds when a tag is added.

some links:

Description

Describe the change simply. Provide a reason for the change.

Include screenshots of any new or modified screens (or at least explain why they were omitted)

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

kdmukai commented 8 months ago

Out of my area of expertise, but this sounds awesome. Opens the door for having less technical people try out PRs or the latest merged into dev, ya?

A few thoughts @dbast:

dbast commented 7 months ago

@kdmukai Rebased the PR and addressed your review findings: one build per merged PR, PR image builds only on demand as resource hungry (can be triggered via comment change, see code), retention days increased to maximum possible.

newtonick commented 6 months ago

ACK