Closed dbast closed 6 months ago
Out of my area of expertise, but this sounds awesome. Opens the door for having less technical people try out PRs or the latest merged into dev
, ya?
A few thoughts @dbast:
@kdmukai Rebased the PR and addressed your review findings: one build per merged PR, PR image builds only on demand as resource hungry (can be triggered via comment change, see code), retention days increased to maximum possible.
ACK
This updates the existing build action to:
enable daily builds = daily PoW that everything works, sources exist, and builds fine together. And it also enables easily testing of merged PRs of the last days for everybody without locally building anything or waiting for a manual workflow_dispatch run. (this also keeps the cache warm, so succeeding triggered builds are a lot faster).one build per mergelower the retention-days to 7 (default 90 days), to not consume to much artifact space with the daily builds enabled.newer builds overwrite older builds in case the artifact cache is fullFor more details see inline comments.
Succeeding PRs can also enable builds for every merge to the dev/main branch or for triggering builds when a tag is added.
some links:
Description
Describe the change simply. Provide a reason for the change.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.