SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

`Controller` cleanup: lazy imports no longer required #496

Closed kdmukai closed 9 months ago

kdmukai commented 1 year ago

Description

At an earlier phase of the test suite refactor (a few months back) and before all the mocking had been put in to wall off the hardware-dependent libraries, the Controller was updated to use lazy imports (not explicitly importing via standard from blah import foo).

But with the test suite in its current form, this workaround is no longer necessary.

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

jdlcdl commented 1 year ago

ACK tested

newtonick commented 9 months ago

ACK, LGTM. Tested without any issues.