SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

Fix unhandled exception when attempting to sign message for custom derivation address #518

Closed BamaHodl closed 7 months ago

BamaHodl commented 8 months ago

Description

This PR fixes the unhandled exception when trying to sign a message from a custom derivation path. The intention in the original code was to show a NotYetImplementedView with a custom text message describing the unsupported feature, however it was implemented as a raise of the view instead of a redirect, as well as a bad initialization of the view (bad parameters).

Screenshot from 2024-01-08 10-49-11

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

newtonick commented 7 months ago

ACK and tested. Congrats @BamaHodl on your first SeedSigner merged PR! I appreciate the time put into the PR.

BamaHodl commented 7 months ago

ACK and tested. Congrats @BamaHodl on your first SeedSigner merged PR! I appreciate the time put into the PR.

Thank you! Very proud to have been able to contribute to this project.