SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

[Minor Improvement] Re-word warning screen title when multisig change/receive addr fails verification #520

Open kdmukai opened 8 months ago

kdmukai commented 8 months ago

Just noticed that the single sig verification failure...

PSBTAddressVerificationFailedView_singlesig_change

...is more strongly worded than the multisig version:

PSBTAddressVerificationFailedView_multisig_change


I recommend a trivial change in the multisig side from "Caution" to "Suspicious PSBT".

There's explicit logic to opt for the softer "Caution" in PSBTAddressVerificationFailedView but I can't think of any reason nor recall any rationale for this.

If there's nothing deeper to consider here, this would be a simple, easy first issue for a new contributor.