SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

Fix Always Wiping Multisig Descriptor at Main Menu #528

Closed 3rdIteration closed 8 months ago

3rdIteration commented 9 months ago

Description

Fix Always Wiping Multisig Descriptor at Main Menu

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

newtonick commented 8 months ago

@3rdIteration I appreciate all the work and interest in the project, but this PR won't get merged as is. These 2000+ lines of code need to be broken into smaller PRs. Maybe you accidentally pushed all these commits and only meant to push a smaller subset related changes you're proposing for the multisig descriptor verification flow?

3rdIteration commented 8 months ago

Ah that's a typo, this one was meant to be the tiny PR ;)

I'll close this one and fix it up at the end of the week.