SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

Replace occurrences of "private key" with "mnemonic seed phrase" in seed_qr README.md #532

Closed jambolo closed 4 months ago

jambolo commented 8 months ago

Replace occurrences of "private key" with "mnemonic seed phrase" in seed_qr README.md.

Description

The seed_qr README.md occasionally uses the term "private key" when "mnemonic seed phrase" is the correct term.

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

newtonick commented 8 months ago

I believe "private key" in this context was used loosely to represent a secret that is stored and entered into a Bitcoin signing device. This said I'm good with this change. I do think it's technically more accurate. @kdmukai this was mostly your original work and better at writing/expressing documentation than I am. Your thoughts?