SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

Remove DireWarning just added in PR #533 #549

Closed newtonick closed 5 months ago

newtonick commented 5 months ago

Description

Describe the change simply. Provide a reason for the change.

Include screenshots of any new or modified screens (or at least explain why they were omitted)

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

kdmukai commented 5 months ago

ACK.

From discussions on Telegram it seems there's strong interest in making some improvements in this area to our current flow, inspired by this series of PRs.

newtonick commented 5 months ago

Looking forward to larger improvements in the multisig change (and self-transfer) verification flows following this PR.

kdmukai commented 1 month ago

To sum up: After #533 and this PR, the net difference is only that the "Next" button text has been changed to "Skip Verification" if the multisig descriptor is not yet loaded.