Closed dbast closed 4 months ago
This is done in advance to open the door for upgrading to newer Python versions on seeedsigner-os at any time.
Fixes / required changes:
E ValueError: mutable default <class 'seedsigner.views.view.Destination'> for field next_destination is not allowed: use default_factory
Describe the change simply. Provide a reason for the change.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:
pytest
If you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.
ACK and tested
newtonick
commented
4 months ago
This is done in advance to open the door for upgrading to newer Python versions on seeedsigner-os at any time.
Fixes / required changes:
E ValueError: mutable default <class 'seedsigner.views.view.Destination'> for field next_destination is not allowed: use default_factoryDescription
Describe the change simply. Provide a reason for the change.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.