search

SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

Signing messages that overflow raise "TextDoesNotFit" exception #570

Closed jdlcdl closed 2 months ago

jdlcdl commented 2 months ago

Reported in the main telegram group, within the past hour:

photo_2024-07-13_10-38-30

Hello Guys! I mine via the Ocean Pool and wanted to set up the "Lightning payout". To do this you need to have a Bolt-12 address or sign this address. I use Sparrow Wallet with Seedsigner. When I want to sign the message from Ocean, this error message appears because the message is too long and the Seedsigner cannot display it. Just a suggestion to the community in case this could be fixed in the future. Best regards!

This happens when the text has nowhere to cleanly break to a new line. https://github.com/SeedSigner/seedsigner/blob/20acf302f6cb9092122770087d3bd7248a346820/src/seedsigner/gui/components.py#L1399

I had resolved this in the past for an experimental multilanguage branch, and it was to not fail on overflow... but then the user would be signing a message that they have not fully viewed on seedsigner screen.

Lagrang3 commented 2 months ago

This is the same issue described in #550

jdlcdl commented 2 months ago

This is the same issue described in #550

Thank you @lagrang3, I'll close this one.