SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

Light refactor of Electrum seed support #571

Closed kdmukai closed 4 months ago

kdmukai commented 4 months ago

Description

Light refactor of #513:

Housekeeping, more robust testing:

Reversions:

Misc:


Settings list issue before the fix in this PR:

After:

SettingsMenuView__Advanced


New/Updated screenshots:

SeedElectrumMnemonicStartView

After moving part of the long settings name into help_text:

SettingsEntryUpdateSelectionView_electrum_seeds


This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

jdlcdl commented 4 months ago

As of f06666eb

ACK tested

Everything is working for me:

kdmukai commented 4 months ago
  • electrum 12w seed with custom extension

Ooh, I should add the "custom extension" wrinkle to the FlowTest.

jdlcdl commented 4 months ago

I've retested this w/ a modified version on top of 6d114f7:

w/ that said, I repeat my ACK tested from earlier today w/ same manual tests performed.

newtonick commented 4 months ago

tACK