Closed kdmukai closed 4 months ago
As of f06666eb
ACK tested
Everything is working for me:
- electrum 12w seed with custom extension
Ooh, I should add the "custom extension" wrinkle to the FlowTest.
I've retested this w/ a modified version on top of 6d114f7:
w/ that said, I repeat my ACK tested from earlier today w/ same manual tests performed.
tACK
Description
Light refactor of #513:
View
should only ever invoke a singleScreen
. Pulled the Electrum seed warning screen into its ownView
. Also gain some modest DRY efficiency and easier future maintenance this way.SettingsEntry
for the Electrum seed option used adisplay_name
value that was way too long to fit in the button list (Settings -> Advanced) that would leave a rendering artifact on the far right edge (scroll past the Electrum option to the bottom of the list).ElectrumSeed
mnemonic validation.Housekeeping, more robust testing:
ElectrumSeed.override_script
.ElectrumSeed
:Reversions:
SeedQREncoder
that were probably added at an earlier phase when Electrum seed + SeedQR was being considered. Downstream effect of this reversion includesseed_views.py
,test_encodepsbtqr.py
,test_seedqr.py
.Misc:
bool
return fromSeed._generate_seed
as it is never used.Seed
:wallet_type
->sig_type
; the term "wallet" is just too overused and poorly specified in bitcoin. Note:embit_utils
does still usewallet_type
but in order to keep this ever-larger PR in check and since it's older, existing code, I left that refactor for another day.Settings list issue before the fix in this PR:
After:
New/Updated screenshots:
After moving part of the long settings name into
help_text
:This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.