SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

[Bugfix] Resolve PSBT parsing error when signing Nested Segwit p2sh-p2wpkh #572

Closed newtonick closed 2 months ago

newtonick commented 2 months ago

Description

only treat p2sh as multisig and don't include p2sh-p2wpkh

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

jdlcdl commented 2 months ago

Confirming:

On current dev at 0f329f6f w/o this pr: after scanning a single-sig nested-segwit PSBT and selecting its seed:

With this pr, scanning, review and signing work for me.