Current dev branch won't show any logs from SeedSigner code when running pytest, regardless of -s, -o log_cli=1, nor --log-cli-level=DEBUG.
Even on a failed test, our logging cannot be surfaced.
This PR:
Alters pyproject.toml to restore the option to review the logs when running pytest AND to insure that the logs are presented when a test fails.
Adds info in tests/README.md
Adds a trivial demonstration test in tests/base.py
Misc:
Bugfix on tests/test_main.py: This test file could not be run individually (pytest tests/test_main.py) because it was not importing tests/base.py which mocks out the problematic dependencies. Wrapping the tests in their own BaseTest class is just cosmetic but also ensures that the important import (from base import BaseTest) gets referenced so an IDE won't consider it an unnecessary import.
This pull request is categorized as a:
[x] Bug fix
[x] Code refactor
Checklist
[x] I’ve run pytest and made sure all unit tests pass before sumbitting the PR
If you modified or added functionality/workflow, did you add new unit tests?
[x] Yes
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.
newtonick
commented
4 months ago
Description
Current
devbranch won't show any logs from SeedSigner code when running pytest, regardless of-s,-o log_cli=1, nor--log-cli-level=DEBUG.Even on a failed test, our logging cannot be surfaced.
This PR:
Alters
pyproject.tomlto restore the option to review the logs when running pytest AND to insure that the logs are presented when a test fails.Adds info in tests/README.md
Adds a trivial demonstration test in tests/base.py
Misc:
pytest tests/test_main.py) because it was not importing tests/base.py which mocks out the problematic dependencies. Wrapping the tests in their ownBaseTestclass is just cosmetic but also ensures that the important import (from base import BaseTest) gets referenced so an IDE won't consider it an unnecessary import.This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.