newtonick
commented
4 weeks ago This PR might fix the dice role entry screen but breaks other screens that use the delete keyboard. When testing the passphrase entry keyboard screen, it throws this exception: UnhandledExceptionView({'error': ['Exception', 'keyboard.py, 204, in __init__', ' charset will not fit in a 4x6 layout | additional_keys']}) | clear_history: True
This exception can also be seen when running the screenshot generator (pytest tests/screenshot_generator/generator.py)
FAILED tests/screenshot_generator/generator.py::test_generate_screenshots - Exception: charset will not fit in a 4x6 layout | additional_keys: [{'code': 'SPACE', 'letter': 'space', 'font': 'compact', 'size': 2}, {'code': 'CURSOR_LEFT', 'letter': '<', 'font': 'regular', 'size': 1}, {'...
fedebuyito
Growning "del" button size property (from 2 to 3) solves navigation issue ("6th dice" -> "del").
solves issue #555
Description
Describe the change simply. Provide a reason for the change.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.