SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
699 stars 161 forks source link

Update encode_qr.py #610

Open fedebuyito opened 1 week ago

fedebuyito commented 1 week ago

Implementing "use_info.network" member provided on HDKey/CoinInfo classes (urtypes/crypto packages-libs folder) for testnet public key exporting option.

Description

Describe the change simply. Provide a reason for the change.

Include screenshots of any new or modified screens (or at least explain why they were omitted)

This pull request is categorized as a:

Checklist

If you modified or added functionality/workflow, did you add new unit tests?

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

fedebuyito commented 1 week ago

582 Exporting for testnet when option is selected.

jgmontoya commented 1 week ago

I couldn't replicate the failing test locally (using python 3.12), @newtonick @kdmukai could you re-run the ci? I suspect that test is maybe just flaky

image
newtonick commented 1 week ago

I can't reproduce the failed CI locally either

image

--I have no idea where this 5 UR frame is coming from or where/why there would be an assertion to compare the 4th and 5th frame to be equal. Odd.-- I looked closer and I have a better understanding of what is going on, but need to dig deeper.

newtonick commented 1 week ago

I'm able to reproduce the failed CI locally now

fedebuyito commented 1 week ago

Thank you, @newtonick. What could you conclude? Any particular on the enviroment to take present for this PR?

jgmontoya commented 1 week ago

@newtonick could you comment on how were you able to reproduce the failing test?

fedebuyito commented 4 days ago

According to suggested by @newtonick, the commits (pytested on local) for implementing "use_info" only on testnet in order to avoid bloat the QR. Updating mainnet case and creating new one for testnet in test_encodepsbtqr.py which was been affected. #582