SeedSigner / seedsigner

Use an air-gapped Raspberry Pi Zero to sign for Bitcoin transactions! (and do other cool stuff)
MIT License
720 stars 168 forks source link

Nunchuk Wallet Xpub broken in 0.8.0 release #614

Open newtonick opened 1 month ago

newtonick commented 1 month ago

Nunchuk expects a BCUR encoded account/xpub from SeedSigner. In the 0.8.0 a refactor changed from a static BCUR encoded QR to the text xpub format. PR494 is were the change happened. My recommendation is to either A) change the Nunchuk coordinator for xpub export to use BCUR (with testing to see if animated QR is supported). B) change the xpub export workflow to not explicitly list coordinators but instead list formats.

Would be ideal if this was fixed in 0.9.0 or a bug fix release (most likely 0.8.1).

See conversation on nostr for additional context: https://njump.me/note1xxnwr5fud0adhxn4he3fyvz2tc3u0tw7nxfuhzhq9wauaduvfq5qjtx2fz