Closed codingpotato closed 2 years ago
Fixed the review comments and added another big change to fix bugs in variable tracking.
Variable
, Element of Containers
and Temporary Value
.dotnet run --project csharp/src/SeedLang.Shell -- -v "Assignment,Comparison" -f examples/seedpython/scripts/sorting/bubble_sort.py
With this PR, the comparison notification events look like
6 if a[j] > a[j + 1]:
Comparison: a:Global[0] 0 > a:Global[1] 1 = False
And assignment notification events look like
8 a[j], a[j + 1] = a[j + 1], a[j]
Assign: a:Global[5] = a:Global[6] 1
8 a[j], a[j + 1] = a[j + 1], a[j]
Assign: a:Global[6] = a:Global[5] 5
It seems Compare VTag
is not needed with this PR. Could the Swap VTag
also be removed?
Please have a review again.
Binary
andComparison
events to include variable information.SubscriptAssignment
events, and combine it intoAssignment
events.Boolean
andUnary
events. It seems that these events are not useful now.After this change, the
Compare VTag
is not needed any more. Please run following command to see the notification ofAssignment
,Binary
andComparison
.