search

Seeed-Studio / ArduinoCore-samd

49 stars 27 forks source link

Add CORE_HAS_LIBB64 definition #37

Closed khoih-prog closed 3 years ago

khoih-prog commented 3 years ago

Add a line to Arduino.h

#define CORE_HAS_LIBB64

to avoid compiler's duplication errors

Pillar1989 commented 3 years ago

@khoih-prog what's this micro mean? How can we use it?

khoih-prog commented 3 years ago

Sorry I didn't clarify it because I think @ansonhe97 knows it and you're in the loop

The reason was specified in PR for WebSockets_Generic Library

Fix compile error for Wio Terminal

Hi @ansonhe97

Thanks for the PR.

I'll merge for the quick fix.

But the best solution is to add to the Seeed-Studio ArduinoCore SAMD core a definition such as

#define CORE_HAS_LIBB64

Something similar to file

core_esp8266_features.h

#define CORE_HAS_LIBB64
#define CORE_HAS_BASE64_CLASS
#define CORE_HAS_CXA_GUARD
#define CORE_HAS_UMM
...

I added that line to Seeed-Studio ArduinoCore SAMD core Arduino.h then forget to mention.

That's why I didn't get any compiler error so far.

The file cencode-Imp.h was also added by typo mistake and will be deleted.

Other quick fixes are adding the definition to

  1. the sketch.
  2. platform.txt
Pillar1989 commented 3 years ago

Got it, thanks.