Seeed-Studio / GPRS_Shield_Suli

GPRS Shield based on SIM900
http://www.seeedstudio.com/depot/GPRS-Shield-V20-p-1379.html?cPath=19_20
MIT License
48 stars 40 forks source link

wait_readable is not waiting - mistake in code #14

Open ranm opened 8 years ago

ranm commented 8 years ago

in "sim900_wait_readable"

instead of : while((unsigned long) (millis() - timerStart) > wait_time * 1000UL)

should be

while((unsigned long) (millis() - timerStart) < wait_time * 1000UL)

(the comparison is the wrong way so it never waits ....)

lanselambor commented 8 years ago

ranm,

Thank you, the mistake has been corrected...

ranm commented 8 years ago

Hey , Are you merging this to the non suli project as well ?