search

Seeed-Studio / Seeed_Arduino_rpcUnified

RTL8720DN wireless abstraction layer using the eRPC protocol.
MIT License
19 stars 10 forks source link

Yasuhirok dev #20

Closed yasuhirok-git closed 2 years ago

yasuhirok-git commented 2 years ago

Network performance improvement

Current performance

$ ping -c 10 192.168.6.6
PING 192.168.6.6 (192.168.6.6) 56(84) bytes of data.
64 bytes from 192.168.6.6: icmp_seq=1 ttl=254 time=85.3 ms
64 bytes from 192.168.6.6: icmp_seq=2 ttl=254 time=100 ms
64 bytes from 192.168.6.6: icmp_seq=3 ttl=254 time=128 ms
64 bytes from 192.168.6.6: icmp_seq=4 ttl=254 time=42.0 ms
64 bytes from 192.168.6.6: icmp_seq=5 ttl=254 time=79.0 ms
64 bytes from 192.168.6.6: icmp_seq=6 ttl=254 time=93.0 ms
64 bytes from 192.168.6.6: icmp_seq=7 ttl=254 time=110 ms
64 bytes from 192.168.6.6: icmp_seq=8 ttl=254 time=51.7 ms
64 bytes from 192.168.6.6: icmp_seq=9 ttl=254 time=52.3 ms
64 bytes from 192.168.6.6: icmp_seq=10 ttl=254 time=74.7 ms

--- 192.168.6.6 ping statistics ---
10 packets transmitted, 10 received, 0% packet loss, time 9015ms
rtt min/avg/max/mdev = 41.973/81.631/128.251/26.187 ms

Performance after improvement

$ ping -c 10 192.168.6.6
PING 192.168.6.6 (192.168.6.6) 56(84) bytes of data.
64 bytes from 192.168.6.6: icmp_seq=1 ttl=254 time=10.1 ms
64 bytes from 192.168.6.6: icmp_seq=2 ttl=254 time=3.66 ms
64 bytes from 192.168.6.6: icmp_seq=3 ttl=254 time=25.8 ms
64 bytes from 192.168.6.6: icmp_seq=4 ttl=254 time=6.53 ms
64 bytes from 192.168.6.6: icmp_seq=5 ttl=254 time=9.93 ms
64 bytes from 192.168.6.6: icmp_seq=6 ttl=254 time=6.07 ms
64 bytes from 192.168.6.6: icmp_seq=7 ttl=254 time=5.44 ms
64 bytes from 192.168.6.6: icmp_seq=8 ttl=254 time=25.6 ms
64 bytes from 192.168.6.6: icmp_seq=9 ttl=254 time=51.3 ms
64 bytes from 192.168.6.6: icmp_seq=10 ttl=254 time=79.7 ms

--- 192.168.6.6 ping statistics ---
10 packets transmitted, 10 received, 0% packet loss, time 9017ms
rtt min/avg/max/mdev = 3.655/22.416/79.689/23.670 ms
Pillar1989 commented 2 years ago

@yasuhirok-git Nice work, thank you very much. @matsujirushi can you help review this PR?

LynnL4 commented 2 years ago

Hello, yasuhirok-git

I noticed that you created a new branch for debugging, did you find some wrong? If so, I'll check this pull request when you're done. Or do you think this pull request is now enough to merge? https://github.com/yasuhirok-git/Seeed_Arduino_rpcUnified/commits/yasuhirok-dev2

Thanks!

yasuhirok-git commented 2 years ago

@LynnL4, thanks for your comment. I continue to improve performance and have not found any problems with the PR'd version. I would like to ask for a merge first.

LynnL4 commented 2 years ago

Hi @yasuhirok-git I removed the debugging code, then merged your PR. Thanks for your contribution

yasuhirok-git commented 2 years ago

Hi, @LynnL4 Thank you for merging. I feel that we need to update the version of the library.properties file. Is this correct?