Closed josor001 closed 2 years ago
Thanks a lot for the PR, which I basically like and only left few comments to consider before it can finally go into main
.
Additional/summarizing remarks:
org.eclipse.core.resources.prefs
file as you did for the Service DSL extractor (cf. https://github.com/SeelabFhdo/lemma/blob/8668f26396ae0a00c8beb5a28768ff47ade93b66/de.fhdo.lemma.servicedsl.extractor/.settings/org.eclipse.core.resources.prefs#L2).I merged this into main
. Please next time perform a git rebase main
on the feature branch before creating the PR, thanks!
As mentioned in the openapi PR, after the service extractor I also finished with the technology DSL extractor. Would be great if it makes it into the main branch 🥇