LemmaUtils and Validators: file import is now case-sensitiv (fix #27) - Githubissues

SeelabFhdo / lemma

Home of the Language Ecosystem for Modeling Microservice Architecture (LEMMA)

MIT License

33 stars 8 forks source link

LemmaUtils and Validators: file import is now case-sensitiv (fix #27) #49

Closed pelkmann closed 2 years ago

frademacher commented 2 years ago

Thank you very much for your extensive work on fixing issue https://github.com/SeelabFhdo/lemma/issues/27 and submitting this PR. Next to my comments, please consider adapting the commit message to something like

DSL Validators: Make import path validation case sensitive (fixes #27)

"DSL Validators" is the name of the LEMMA set of components that are primarily concerned by the commit.
"Make import path validation case sensitive" is immediately consistent with the issue title.
We use "fixes" instead of "fix" to refer to fixed issues.

Again, thanks a lot!

pelkmann commented 2 years ago

Retest under Windows was successful