SeeuSim / pe

0 stars 0 forks source link

UG Correct Phone Number restriction example not valid #11

Open SeeuSim opened 1 year ago

SeeuSim commented 1 year ago

The example under Emergency Contact Number is not valid.


Screenshot 2023-04-14 at 2.46.10 PM.png

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

User Guide: Invalid field format

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


While the regex that validates this in the codebase (Phone) only allows for digits, the user guide says other characters may be entered (space, '+', etc.).


Screenshot 2023-04-14 at 3.33.50 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#4072] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for bringing this to our attention. It appears that when we updated the phone field restriction, we overlooked updating the corresponding information in the user guide.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: While the validation may be using the same Phone field's validation, this is with regards to an input of a separate field (in this case, Emergency Contact).

As such, this is not a duplicate issue and should be a flaw under the Emergency Contact Field feature, and its documentation.