SeeuSim / pe

0 stars 0 forks source link

Preferences file invalid values not indicated, saved #16

Open SeeuSim opened 1 year ago

SeeuSim commented 1 year ago

Instead of indicating to the user that the preferences file is invalid (negative width), it simply resizes to the smallest width possible and does not edit/save the preferences file to be valid.


Screenshot 2023-04-14 at 2.58.42 PM.png

soc-se-bot commented 1 year ago

Team's Response

The preference.json file is not meant to be meddled by the user so we do not raise such mistake to them but automatically resize the window to the smallest size. does not edit/save the preferences file to be valid is inaccurate because the system will automatically save the size of the window before user exits(in this case if user does not adjust the size of the window, the values corresponding to the smallest window size will be saved), which fixes the corrupted value.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Regardless, as the guide does mention a user preferences file being saved, this could lead to system administrators using this feature and setting a resolution for all of their clinicians' devices.

In the event a system administrator has made a mistake, the app should indicate so and rectify the error within the file without the user's input.

As such, this is a flaw in either the Documentation of this feature, UI feature or the Preferences feature, as it does not: i) validate the preferences file, or ii) indicate errors to the user, or iii) mention that the preferences will be set automatically on resize and should not be tampered with.

This warrants at least a Very Low severity, as it is a cosmetic flaw at best and could affect users at worst.