SeeuSim / pe

0 stars 0 forks source link

Tampering with JSON file for certain fields allowed #9

Open SeeuSim opened 1 year ago

SeeuSim commented 1 year ago

When the app uses the JSON file to load data, and a certain patient's contact is updated to a non-personal contact number (i.e. 999), the app allows it and does not validate the number that it is a personal/landline number.


Screenshot 2023-04-14 at 2.38.30 PM.png

nus-pe-script commented 1 year ago

Team's Response

This is a feature of our app. Our app does not check the validity of a number because while one number might be a landline number in Singapore, it might be a perfectly fine number in a different country. We want to keep our options open as we are not aiming only for Singapore's market. So we'll leave it to the receptionists' discretion.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]