Closed Sefa76 closed 2 months ago
Hello @jl-bernal , I wanted to unravel a bit of what this issue is about and do kind of a task list. For the sake of clarity I have linked a new branch just for this task. Also there are some open points to discuss.
The necessary tasks for the line broadening are:
The suppression due to resolution was previously handled in line_obs. I think we might also just be able to outsource this. For the suppression we have to do:
Finally we also need to add the convolution with the survey volume We can stay pretty close to the excising lim implementation. I wanted to add them to the (still barren) covariance file as we will use the windows also for the SSC. So for completeness' sake:
Hi @Sefa76, thanks for taking care of this and open the thread.
Some comments regarding the tasks
Hello @jl-bernal,
Thank you for the reply and the explanation.
Regarding your first point: The reason why I wanted to have it in L-moments, is that that function enters in the RSD term and in the shotnoise term. I compared to the old lim code and found that this is similar to how the old function Pshot
and L2mean
, or Pk_twohalo
and Tmean
did handle the v_of_M
Thank you for helping me with my shot noise confusion again. I also thought about an interesting Gedankenexperiment: Lets say the shot noise (be it the one-halo or some additional shot noise) was not multiplied by the suppression. That would mean that for two experiments one with a very good resolution and one with a bad resolution both would measure the same small scale power spectrum. As the measured power spectrum of the bad-resolution experiment would be much more suppressed it would actually be better in measuring the shot noise as it sees the effect on a wider range of scales (whatever that means)
The outsourcing part was poorly explained by me sorry: If I wanted to follow my design strategy and separate the effects of for example Cosmology and Astrophysics one could argue that the detector/ survey effects should also be separate as they do not really depend on that. So yeah it is just a question of tidiness where I want to put that. And if you would be even more pedantic the same question arises for the sky selection window functions.
I hope this explains a bit better what I was thinking
Yes the normal for-loop integration takes about ~10 minutes so we want to go through the MCfit ideas to do the integration. I will clean it up a bit and then add it as a switch but honestly this can only be used to compare. To have it clean I will open a new issue for the "real-space" computation
https://github.com/Sefa76/SSLimPy/blob/67b935d6117ae8b0bea9bb47435758c42ef84785/SSLimPy/LIMsurvey/PowerSpectra.py#L310