Sefaria / Sefaria-Mobile

Sefaria for iOS and Android
http://www.sefaria.org
32 stars 20 forks source link

fix(TextColumn): show last segments when connections panel is open. #128

Closed YishaiGlasner closed 1 month ago

YishaiGlasner commented 1 month ago

Bugfix

The problem: When connections panel is open, one cannot navigate to the last segment(s) (inless it's long enough). Also, when pressing it, the connections panel will open but on a previous segment.

The solution: Adding bottom padding to TextColumn.

Undesired side effect: Now, when the connections panel is open, one can scroll all the text out of the screen.

Todo - a better solution: Adding an empty in renderListFooter enables scrolling to the last segment. Still, on pressing the last segment it wil remain 'under' the connections panel. This is because the scrollToLocation happens before the panel is opened. A better wolution will find how to scrollToLocation after opening the panel.