Sefaria / Sefaria-Playwright-Tests

Tests bulletproof Sefaria from bugs. They are easy to contribute and will make our digital library more resilient. Questions? Contact us at developers@sefaria.org
1 stars 0 forks source link

Translation Version Name in Title Bar #18

Open saengel opened 5 months ago

saengel commented 5 months ago

Title: Verify display of translation version name in the title bar. Test:

  1. Open a translated text.
  2. Verify that the translation version name (e.g., "The Rashi chumash by Rabbi Shraga Silverstein") is displayed in English regardless of contentLanguage.
b-w-cole commented 3 months ago

Hi @saengel! I'm working on this one. I'm checking the following:

Is there anything else you'd like me to check?

b-w-cole commented 3 months ago
saengel commented 3 months ago

I think that works for now! We can always add more later if needed. Thank you!

b-w-cole commented 3 months ago

Ok, sounds great! As mentioned in Discord, I found that there is no default translation title for Hebrew source language in any interface language. I can remove this part of the test if desired. I was originally testing the default source language, but I'm going to expand it to the usual interface/source combo of 4.

b-w-cole commented 3 months ago

There's an opportunity here for another function in Utils and some vars in Globals that will change the source language for us. I'll submit a PR and you can tell me what you think.

b-w-cole commented 3 months ago

Also, I noticed there is a bilingual aspect to translation names for Hebrew Interface/English Source only that I'm guessing is intentional, as I'm seeing a good number of translations that are spelled out in Hebrew.

image

b-w-cole commented 3 months ago

(That being said, I already learned from this translation, so thanks for suggesting it as an example)

saengel commented 3 months ago

Okay sounds good! Thank you for the efforts here.