search

Sefaria / Sefaria-Project

New Interfaces for Jewish Texts
https://www.sefaria.org
654 stars 268 forks source link

fix(Topic Pages): encodeURI should be used instead of encodeURIComponent #1992

Closed stevekaplan123 closed 2 months ago

stevekaplan123 commented 2 months ago

Description

This addresses getBulkText sending out 3800 character URLs.

Code Changes

Even though a previous attempt was supposed to have fixed this, in one case, encodeURI was used and in another, encodeURIComponent. This is problematic because encodeURI doesn't encode colons so the previous attempted fix did not do the job. This PR makes both cases encodeURI.