search

Sefaria / Sefaria-Project

New Interfaces for Jewish Texts
https://www.sefaria.org
653 stars 265 forks source link

Adding notes on text is buggy #69

Closed levinotik closed 10 years ago

levinotik commented 10 years ago

I added a note to the first law in the Mishne Torah's Sefer Hamada. I later edited it to change the title. I then edited it a third time. After this, the note disappeared completely after saving it.

blockspeiser commented 10 years ago

Thanks. It looks like the citation that this note was anchored to got changed from "Mishneh Torah, Foundations of the Torah 1" to false on the second save. (you can see the empty value on the second edit here http://www.sefaria.org/contributors/oKHS_Hwsh2HriQ5iqbBfCeWp7plzum). Will need to debug...

In the meantime, I restored your note to its correct place by changing the citation in the DB.

On Mon, Dec 30, 2013 at 3:43 PM, Levi Notik notifications@github.comwrote:

I added a note to the first law in the Mishne Torah's Sefer Hamada. I later edited it to change the title. I then edited it a third time. After this, the note disappeared completely after saving it.

— Reply to this email directly or view it on GitHubhttps://github.com/blockspeiser/Sefaria-Project/issues/69 .

blockspeiser commented 10 years ago

With the recent changes that allow adding private notes, this functionality was updated and tested again. Thanks...