Sefiraat / SlimeTinker

An addon that is trying to recreate Tinker's Construct within Slimefun. Adds new customisable tools with leveling and modifiers.
GNU General Public License v3.0
24 stars 32 forks source link

Incompatibility with Itemsadder causing tool duplication #150

Open masonalexone opened 2 years ago

masonalexone commented 2 years ago

Checklist

Description

Im using the latest DEV version of Slimetinkerer on 1.18.2 Purpur with Java 17, and the Itemsadder plugin.

When using a pickaxe with the following stats and mining a custom ore from Itemsadder's default configs, the pickaxe duplicates, creating an exact copy of itself in my inventory.

Netherite Pickaxe Enchants: Eff 10, Fortune 10, Unbreaking 10, Mending 1 H: Fortune Singularity B: Silicon R: Steel Fortunate Slow Learner Lightweight Level 17 (636 / 8650) Modifier Slots: 8 Emerald Level 4 Lapis Lazuli Level 5

Steps to reproduce

  1. Install Itemsadder on 1.18.2 Purpur with Slimetinker, Slimefun, and any dependencies
  2. Create the pickaxe listed
  3. Spawn in an itemsadder ore with /iaget itemsadder:turquoise_ore
  4. Place it and mine it with the tool
  5. Watch as the tool duplicates!

Expected behavior

The item to not duplicate. Possibly the fortune portion of the tool is attempting to duplicate the ore's drops and is instead duplicating the tool itself.

Server log

https://pastebin.com/

Error report

No response

Server software

Purpur

Minecraft Version

1.18.x

CS-CoreLib Version

Slimefun version

Dev 1026 image

SlimeTinker version

Dev 77

Other plugins

Itemsadder, possibly the SF Itemsadder extension too.

Sefiraat commented 2 years ago

I would love to help here, I really would (and it's likely I screwed something up on my side) but as ItemsAdder is a premium plugin and closed source, I have no real way to begin triaging my mistake here. Sorry.

LoneDev6 commented 1 year ago

I added you to the buyers list so that you can check out the problem too :D https://www.spigotmc.org/resources/73355/

Thanks for your cooperation!

Sefiraat commented 1 year ago

Thanks for the report @masonalexone ill take a look shortly :)

And thanks for access to the jar @LoneDev6. Free premium plugin eh, knew I got into this for a reason ;)

LoneDev6 commented 1 year ago

Any news on the issue? In the meantime I'll close it on my side for inactivity: https://github.com/PluginBugs/Issues-ItemsAdder/issues/2219

LoneDev6 commented 1 year ago

Might be related to this: https://github.com/PluginBugs/Issues-ItemsAdder/issues/2687 It should be fixed in the upcoming ItemsAdder 3.4.1e. Please test and let me know (after I release the update).