Segelzwerg / SportToolBox

This is a website where you calculate different metrics used in sport. It is meant to collect calculators into one website for the convenience of the athletes.

GNU General Public License v3.0

4 stars 21 forks source link

issue-92: remove @Sneaky-Throws from tests dev branch #104

Closed EEM86 closed 3 years ago

EEM86 commented 3 years ago

Remove @SneakyThrows from tests

Segelzwerg commented 3 years ago

@EEM86 I think you mixed up the branches during commit.

EEM86 commented 3 years ago

@EEM86 I think you mixed up the branches during commit.

@Segelzwerg Hm, I had not done it. Let's see. I saw the last commit on develop branch on 10/10/2020 #eedd and further my commit with small changes.

Segelzwerg commented 3 years ago

@EEM86 I think you mixed up the branches during commit.

@Segelzwerg Hm, I had not done it. Let's see. I saw the last commit on develop branch on 10/10/2020 #eedd and further my commit with small changes.

Yeah I did a hotfix for the CI, but I think the toString() is out of scope here and you could do that in the PR for #87

Segelzwerg commented 3 years ago

@EEM86 I think you mixed up the branches during commit.

@Segelzwerg Hm, I had not done it. Let's see. I saw the last commit on develop branch on 10/10/2020 #eedd and further my commit with small changes.

Yeah I did a hotfix for the CI, but I think the toString() is out of scope here and you could do that in the PR for #87

Oh I get it. You merged your stuff in your develop. So it is merged here too.

EEM86 commented 3 years ago

@EEM86 I think you mixed up the branches during commit.

@Segelzwerg Hm, I had not done it. Let's see. I saw the last commit on develop branch on 10/10/2020 #eedd and further my commit with small changes.

Yeah I did a hotfix for the CI, but I think the toString() is out of scope here and you could do that in the PR for #87

Oh I get it. You merged your stuff in your develop. So it is merged here too.

Ah oh, I saw that you merged my previous commit and just pulled the develop branch and pushed new commit with #95 task.

Segelzwerg commented 3 years ago

@EEM86 I think you mixed up the branches during commit.

@Segelzwerg Hm, I had not done it. Let's see. I saw the last commit on develop branch on 10/10/2020 #eedd and further my commit with small changes.

Yeah I did a hotfix for the CI, but I think the toString() is out of scope here and you could do that in the PR for #87

Oh I get it. You merged your stuff in your develop. So it is merged here too.

Ah oh, I saw that you merged my previous commit and just pulled the develop branch and pushed new commit with #95 task.

Yeah, I merged the CI stuff, because I noticed it not working. I think I have to do some more on it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #104 into develop will not change coverage. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #104   +/-   ##
==========================================
  Coverage      86.01%   86.01%           
  Complexity       229      229           
==========================================
  Files             35       35           
  Lines            522      522           
  Branches          32       32           
==========================================
  Hits             449      449           
  Misses            51       51           
  Partials          22       22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fd0a81...9d3d4de. Read the comment docs.

EEM86 commented 3 years ago

Can you revert the toString() stuff as it will decrease coverage and is out of scope in this PR?

Sure. One minute, please.