Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
700 stars 145 forks source link

Install fails with Postgres 9.5 beta 2 #120

Closed djrobstep closed 8 years ago

djrobstep commented 8 years ago

I get the following error when attempting to install with 9.5 beta 2

src/multicorn.c: In function ‘multicornGetForeignPlan’:
src/multicorn.c:354:9: error: too few arguments to function ‘make_foreignscan’
  return make_foreignscan(tlist,
         ^
In file included from src/multicorn.c:13:0:
/usr/include/postgresql/9.5/server/optimizer/planmain.h:46:21: note: declared here
 extern ForeignScan *make_foreignscan(List *qptlist, List *qpqual,
                     ^
src/multicorn.c:363:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
<builtin>: recipe for target 'src/multicorn.o' failed
make: *** [src/multicorn.o] Error 1
ERROR: command returned 2: make PG_CONFIG=/usr/bin/pg_config all

Worked fine with beta 1

rdunklau commented 8 years ago

Thanks, fixed in 672625e8f18c23a8aea3f938043ca04f6995c7e1

df7cb commented 8 years ago

Hi, will there be a new release to get the 9.5 fix out? I'd like to update the Debian packages.

rdunklau commented 8 years ago

There was a release on the 28th, but I just realized that the tag was created here as "1.3.0" instead of "v1.3.0".

df7cb commented 8 years ago

Oh right, that's why Debian's look-for-new-version magic didn't find it. Thanks for fixing the tag!