Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
701 stars 145 forks source link

Suppress messages from DROP CASCADE #138

Closed df7cb closed 6 years ago

df7cb commented 8 years ago

DROP CASCADE outputs vary slightly in the DETAIL part: -drop cascades to user mapping for postgres +drop cascades to user mapping for postgres on server multicorn_srv

Suppress these using SET client_min_messages=WARNING;

(I haven't actually verified how much these variations depend on the PG version used. If it matters I can so some digging, but I'd think the messages aren't really interesting so dropping them is a good idea anyway.)

Original patch by Markus Wanner.

df7cb commented 8 years ago

For reference, here's a build log with the variations visible: https://ci.debian.net/data/packages/unstable/amd64/p/postgresql-multicorn/20150704_212134.autopkgtest.log.gz

rdunklau commented 8 years ago

I'm not against the proposed change since its mostly noise anyway, but what it is the problem with how it works now ? The tests pass from 9.2 to 9.5 as far I know.

df7cb commented 8 years ago

Valid question, I'll get back with more data!

df7cb commented 6 years ago

Hi, I can't figure out anymore why I did these changes, maybe at some point during debugging I was seeing differences in the cascade output, or it was some issue with 9.1. I'll close the PR now - if you still want to suppress the "noise", reopen. Cheers!