search

Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
700 stars 145 forks source link

Split out declarations and definitions into .h and .c #153

Open Bengreen opened 8 years ago

Bengreen commented 8 years ago

Current C code has some of the prototypes inside or at the beginning of the .c files.

I have found that this causes some errors where functions had their return types implicity assumed later to be found out that this was wrong resulting in a SEGV. This occurred when modifying the c code and not realising that you have to manually add prototypes for all functions you wish to use at the beginning of the source you are editing.

I have created .h files for all the .c files and moved all non-static prototypes into them.

This should make future editing of c code much easier.

galuszkak commented 5 years ago

Hi @Bengreen , I see that this PR has also changes from #154 and #152 . Could You seperate changes with .h and .c into seperate branch, so it has only this changes not the others?