search

Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
701 stars 145 forks source link

adds widows 64 build #177

Closed vmora closed 2 years ago

vmora commented 7 years ago

Hi,

Here's a minimal cmake project config for windows.

I started with postgres 9.6.1 x86-64 install from here http://www.enterprisedb.com/products-services-training/pgdownload#windows with pyhton3 langage support

I was able to compile with visual studio 2015 (community), the commands are comments at the bottom of the CMakeLists.txt. I cpy/pasted the Relase/multicorn.dll, .control and .sql files in the appropriate folders.

create extension multicorn;
CREATE EXTENSION

The changes to the source are minimal (2xPGDLLEXPORT), but I'm not sure the extension actually works.

I'll try and improve the CMakeLists.txt to find postgres and python3 automagically, install, and run the tests.

If someone feels like given a hand, help is very welcome (time is a scarce commodity, and windows is...).

vmora commented 7 years ago

server crash on create server

vmora commented 7 years ago

Everything seems fine now.

I only tested with the simple wrapper here http://multicorn.org/implementing-an-fdw/ though.

The changes shouldn't affect anything (only tested the build on linux).

If the next StackBuilder could include multicorn, it would be great.

vmora commented 7 years ago

Here are the generated binaries (RelWithDebInfo)

multicorn .zip

vmora commented 7 years ago

The cmakelists.txt is far from perfect, but the changes shouldn't affect the code. So I removed the [WIP] tag from the title.

I think the export flags plus the draft cmakelists.txt is worth including in the main repos.