search

Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
699 stars 145 forks source link

Update for PostgreSQL v11 #210

Closed jeffjanes closed 5 years ago

jeffjanes commented 5 years ago

The old way of accessing attributes has finally been removed in favor of TupleDescAttr, so change the code to use that macro. This macro exists back to 9.2.

This fixes issue #206.

galuszkak commented 5 years ago

Hey @rdunklau @rdunklau-4ct @rvernica,

It would be great if this can be merged as PostgreSQL 11 is with us for some time.

Thanks for hard work!

brenochoa commented 5 years ago

Unfortunately, I believe the Kozea folks have stopped giving a damn about this project and abandoned it, as they haven't done anything about it or replied to requests for well over a year now. I wish they would give collaborator access to people keen on maintaining it before the project rots away.

liZe commented 5 years ago

Unfortunately, I believe the Kozea folks have stopped giving a damn about this project and abandoned it, as they haven't done anything about it or replied to requests for well over a year now.

We've not abandoned it (we use it in production), but it's true that we don't spend time on this project anymore.

I wish they would give collaborator access to people keen on maintaining it before the project rots away.

Anyone interested? :smile:

galuszkak commented 5 years ago

@liZe I'm interested to help here with maintenance.

liZe commented 5 years ago

I'm interested to help here with maintenance.

Thank you! I've invited you in the Multicorn team. Feel free to contact me if you need anything else (like PyPI access for example).

galuszkak commented 5 years ago

@liZe thank You!

Is there any process setup for package release? I assume because You need pgxn account this is maybe automated via any CI/CD process? Or it's just account that someone owns and releases are manual?

Thanks!

rdunklau commented 5 years ago

Hi ! I'm the one managing the PGXN account for this project. I'm not really maintaining it anymore since I don't use it myself... I'll try to see if pgxn has a concept of "organizations" now.

@liZe I didn't event know we had a Multicorn organization :) Maybe we should move the repo to that namespace as a first step ?

liZe commented 5 years ago

@liZe I didn't event know we had a Multicorn organization :) Maybe we should move the repo to that namespace as a first step ?

Hi :smile:! It's not an organization, it's a team. If anyone wants to create a separate organization, there's no problem to move the repository.

galuszkak commented 5 years ago

@liZe @rdunklau let's move that discussion to maybe another issue, I will merge this PR as sounds it's fixing issue with PostgreSQL 11.

galuszkak commented 5 years ago

Moved discussion to #221