Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
699 stars 145 forks source link

Adapt to get_attname change in PG11 (8237f27b504ff1) #214

Closed df7cb closed 3 years ago

df7cb commented 5 years ago

Also catch output variation in cache invalidation test, cause to be determined.

regression.diffs *** /tmp/autopkgtest.eO0dZY/tree/test-3.6/expected/multicorn_cache_invalidation.out 2017-11-23 13:02:27.137612090 +0100 --- /tmp/autopkgtest.eO0dZY/tree/results/multicorn_cache_invalidation.out 2018-10-19 11:25:57.017215290 +0200


* 304,314 **

ALTER foreign table testmulticorn rename test1 to testnew; select * from testmulticorn limit 1; NOTICE: [] NOTICE: ['test2', 'testnew'] ! test2 | testnew ! -----------+----------- ! test2 1 0 | test1 2 0 (1 row)

DROP USER MAPPING for postgres SERVER multicorn_srv; --- 304,316 ----

ALTER foreign table testmulticorn rename test1 to testnew; select * from testmulticorn limit 1;

df7cb commented 5 years ago

I got Multicorn to build with PG11 on Debian by appying #210 and #214. I'm not happy with the latter one as it suppresses a regression in the cache invalidation test, but it's a start. Hopefully someone with more clue about the code can have a look and improve on it.

galuszkak commented 5 years ago

@ChristophBerg I will try look into this to fix that. I already merged #210 . I want to understand why regression tests are failing and what can be done to fix that issue. Did You had maybe a chance to look into this?

df7cb commented 5 years ago

Sorry, I have no idea what the test is supposed to be testing, I'm only the packager who wanted Multicorn to build+test successfully on Debian...

df7cb commented 3 years ago

Master compiles fine so I think this isn't relevant anymore.