Build for Windows - Githubissues

dwickern commented 3 years ago

I ported multicorn to Windows based on the work in https://github.com/Segfault-Inc/Multicorn/pull/177

I've got CI/CD running which you can preview here: https://github.com/dwickern/Multicorn/releases/tag/refs%2Fpull%2F1%2Fmerge

To install, download and extract the .zip to your Postgres installation, and pip install the corresponding .whl

I have a few TODOs:

Cross-build for different Python versions. Currently I'm building against 3.7 which produces artifacts like multicorn_pg11-1.4.0-cp37-cp37m-win_amd64.whl. Do we need to produce different artifacts for Python 3.6, 3.8, 2.x, etc? I'm not experienced with Python.
Run tests on Windows CI. I did run the tests locally using pg_regress. 8 out of 18 tests failed, mostly due to minor differences in output. FilesystemFdw won't work because fcntl does not exist on Windows.

rdunklau commented 3 years ago

Wow, thank you ! This has been a requested feature for as long as Multicorn exists. I'm afraid I don't know much about windows to review it properly, but if it doesn't change the way it works on unixes, I'll gladly merge that.

dwickern commented 3 years ago

My branch should work the same as before on unix systems. I'm trying to run travis CI against my branch to verify, but each build sits in a queue for 10 hours.

dwickern commented 3 years ago

All tests pass on both Windows and Linux now https://github.com/dwickern/Multicorn/actions/runs/401814635

Segfault-Inc / Multicorn

Build for Windows #264