Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
697 stars 145 forks source link

OR filters not supported #76

Open txntxn opened 9 years ago

txntxn commented 9 years ago

Do you know how I can get Postgres OR working with Multicorn?

I get this message: WARNING: unsupported expression for extractClauseFrom

Over email @rdunklau asked for a proposal for implementing these quals that is backwards compatible. My proposal to maintain backwards compatibility is as follows:

This approach is nice because existing code can be reused and extended to add the OR_EXPR, and you can recurse.

Over email @rdunklau replied:

"it may be better to offer a separate qual API entirely.

Depending on an attribute defined on the foreign-data-wrapper (QUAL_API = 2) for example, the qual representation would either be as-is, or be a binary tree more closely reflecting the internal structure of PostgreSQL expression trees.

This would allow both to coexist peacefully, while keeping the default of having everything be simple enough."

txntxn commented 9 years ago

This appears related to https://github.com/Kozea/Multicorn/issues/30